-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add deferrable support for MwaaDagRunSensor #47527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensor Also Includes: - Unit tests - Support for `AwsGenericHook` and `AwsBaseWaiterTrigger` to allow overriding boto waiter config for custom success and failure states in the sensor - Changes to `aws.utils.waiter_with_logging.async_wait` to include info about latest response in exception
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Mar 8, 2025
Depends on apache#47527 because of the MwaaDagRunCompletedTrigger
9ac9c70 to
d328195
Compare
ferruzzi
reviewed
Mar 10, 2025
ferruzzi
reviewed
Mar 10, 2025
ferruzzi
reviewed
Mar 10, 2025
providers/amazon/src/airflow/providers/amazon/aws/triggers/mwaa.py
Outdated
Show resolved
Hide resolved
ferruzzi
approved these changes
Mar 10, 2025
Contributor
ferruzzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending passing CI
60074e5 to
f222884
Compare
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Mar 11, 2025
Depends on apache#47527 because of the MwaaDagRunCompletedTrigger
ferruzzi
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Add wait/defer support - MwaaTriggerDagRunOperator Depends on #47527 because of the MwaaDagRunCompletedTrigger
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Add MwaaDagRunCompletedTrigger and deferrable support for MwaaDagRunSensor Also Includes: - Unit tests - Support for `AwsGenericHook` and `AwsBaseWaiterTrigger` to allow overriding boto waiter config for custom success and failure states in the sensor - Changes to `aws.utils.waiter_with_logging.async_wait` to include info about latest response in exception
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* Add wait/defer support - MwaaTriggerDagRunOperator Depends on apache#47527 because of the MwaaDagRunCompletedTrigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Includes:
AwsGenericHookandAwsBaseWaiterTriggerto allow overriding boto waiter config for custom success and failure states in the sensoraws.utils.waiter_with_logging.async_waitto include info about latest response in exception^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.