Skip to content

Conversation

@vatsrahul1001
Copy link
Contributor

related to #42360

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 10, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @jedcunningham @vincbeck

What type of permissions do we want on dag versions ? Do we want a new entity ? Or dag related dag access / code is enough ?

@vincbeck
Copy link
Contributor

cc: @jedcunningham @vincbeck

What type of permissions do we want on dag versions ? Do we want a new entity ? Or dag related dag access / code is enough ?

I think we should add a new entity in DagAccessEntity

@Lee-W Lee-W force-pushed the AIP-84-auth-dag-versioning branch from 6028d26 to 444ec51 Compare March 13, 2025 10:57
@Lee-W Lee-W requested a review from pierrejeambrun March 13, 2025 11:05
@Lee-W Lee-W force-pushed the AIP-84-auth-dag-versioning branch from 444ec51 to aaebc9d Compare March 13, 2025 11:32
@pierrejeambrun
Copy link
Member

restarting the failed job. We should be good to go. (even if we know it's unrelated k8s flaky failure)

@Lee-W
Copy link
Member

Lee-W commented Mar 14, 2025

merging

@Lee-W Lee-W merged commit d5ea56a into apache:main Mar 14, 2025
89 checks passed
@Lee-W Lee-W deleted the AIP-84-auth-dag-versioning branch March 14, 2025 00:28
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
* add auth to dag versions endpoints

* adding new DagAccessEntity for DAG Version

* feat(security): add DagAccessEntity.VERSION

---------

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* add auth to dag versions endpoints

* adding new DagAccessEntity for DAG Version

* feat(security): add DagAccessEntity.VERSION

---------

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants