AIP-38 Move token handling to axios interceptor #47562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
jscheffl and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:providers
area:UI
pierrejeambrun
commented
Mar 10, 2025
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py
Show resolved
Hide resolved
bbovenzi
approved these changes
Mar 10, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Much better than useEffect!
Contributor
|
When we add logout. We may want to use an axios interceptor too. |
pierrejeambrun
force-pushed
the
aip-38-move-token-handling-to-axios-interceptor
branch
from
96b5792 to
32bba44
Compare
pierrejeambrun
deleted the
aip-38-move-token-handling-to-axios-interceptor
branch
github-project-automation
bot
moved this from In progress
to Done
in AIP-38: Modern Web Application
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the router loader query (config) is done before the token handler gets a chance to actually handle the token. (BaseLayout, but the router loader is done before rendering the BaseLayout)
#47487 introduces auth/perm on the config endpoint which will induce a 401 redirection loop.
This moves the token handling to the axios interceptor, this way outside of rendering / loader consideration, the token handler (to retrieve, or save) is always executed before doing a request.