-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Use a single http tag to report the server's location to front end, not two #47572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let me just try this locally, one moment please :) |
|
@pierrejeambrun Please. It seemed to work find for me in dev and prod modes |
|
Well, I just tried on main and things do not seem to work anymore either..... :( but the errors are different |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thanks.
Maybe later we will still want two settings in case the static file are hosted somewhere else (cdn) but for now that's much cleaner.
3d83702 to
7dcc872
Compare
…ot two
Previously we had both a `<base href="">` tag and a `<meta
name="backend-server-base-url" content="">` tag that contained almost the same
value -- one had a trailing `/` and the other didn't.
That irked me, so I updated things so the XHR requests take the URL based on
the `<base>` tag instead.
In order to make this change I made the following changes:
- Instead of erroring if the URL does have a trailing `/`, the behaviour is
now to add it if it's missing. This makes it easier kn users
- This necessitated updating the Auth Managers to use a proper URL function,
not string concatenation, to build the URLs
The change to `conf.set` is a side-effect/fix to allow `conf.set("api",
"base_url")` to work -- otherwise it errored with "No section found" with only
the defaults present
7dcc872 to
89caf69
Compare
…ot two (apache#47572) Previously we had both a `<base href="">` tag and a `<meta name="backend-server-base-url" content="">` tag that contained almost the same value -- one had a trailing `/` and the other didn't. That irked me, so I updated things so the XHR requests take the URL based on the `<base>` tag instead. In order to make this change I made the following changes: - Instead of erroring if the URL does have a trailing `/`, the behaviour is now to add it if it's missing. This makes it easier kn users - This necessitated updating the Auth Managers to use a proper URL function, not string concatenation, to build the URLs The change to `conf.set` is a side-effect/fix to allow `conf.set("api", "base_url")` to work -- otherwise it errored with "No section found" with only the defaults present.

Previously we had both a
<base href="">tag and a<meta name="backend-server-base-url" content="">tag that contained almost the samevalue -- one had a trailing
/and the other didn't.That irked me, so I updated things so the XHR requests take the URL based on
the
<base>tag instead.In order to make this change I made the following changes:
/, the behaviour isnow to add it if it's missing. This makes it easier kn users
not string concatenation, to build the URLs
The change to
conf.setis a side-effect/fix to allowconf.set("api", "base_url")to work -- otherwise it errored with "No section found" with onlythe defaults present
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.