Fix get_menu_items in FAB auth manager
#47688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
force-pushed
the
vincbeck/fix_get_menu_items
branch
from
b582b30 to
e23ea96
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Checking on my phone so I might be missing something as it’s hard to read, but I am not sure how this will fix the issue on the fast api side. This will yield an exception and we will not be able to get the items are we ?
vincbeck
force-pushed
the
vincbeck/fix_get_menu_items
branch
from
e23ea96 to
f6c7ec3
Compare
Contributor
Author
You're right. I also realized that the URLs do not change between the different implementation (DB, LDAP, Kerberos ...). So I simplified it and hardcoded the URLs. Simple is better |
bugraoz93
approved these changes
Mar 12, 2025
jason810496
approved these changes
Mar 13, 2025
Lee-W
approved these changes
Mar 13, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #47662, there is a bug in the method
get_menu_itemsof FAB auth manager.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.