AIP-84 Add logout endpoint #47725
Merged
AIP-84 Add logout endpoint #47725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
ephraimbuddy,
jscheffl and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Member
Author
|
cc: @vincbeck |
Contributor
|
Yes we need to do the same mechanism as login :/ I can create the methods in the auth managers if you want then, you can use it in this PR |
Member
Author
|
That would be great, thanks |
Contributor
pierrejeambrun
force-pushed
the
47559-backend
branch
from
9b6ee78 to
b9109f4
Compare
vincbeck
approved these changes
Mar 13, 2025
vincbeck
approved these changes
Mar 13, 2025
Member
Author
|
Unrelated failure, merging. |
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
* AIP-84 Add logout endpoint * Adjust following AuthManager update * Address PR comment * Fix CI
This was referenced Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #47559
This add the logout endpoint.
When I try this locally with the
FabAuthManagerwe get the same problem as #47662, we are working outside of a request context.I think we need to do the same thing we do for the login -> redirect to a flask
login_urlso this is rendered with the WSGI middleware and passing the flask context along. (Also this needs to not crash when no user is logged in)