Skip to content

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Mar 15, 2025

fixes #47003

Copying comment from #47003 :

After converting the field to a BS3PasswordFieldWidget , when we paste PEM key with new lines, this field automatically removes new lines.

For example:

key_start
text
key_end
is now converted to a single line key_starttextkey_end .

And, when format the PEM key to replace new lines with "\n" , it is actually saved as "\n".

For example:
key_start\ntext\nkey_end to become key_start\ntext\nkey_end

Here's what I'm thinking to do:

Update docs to inform users to pass PEM key by replacing new lines with \n's
In the code, I'll just replace \n with \n

@rawwar rawwar requested review from mik-laj and potiuk as code owners March 15, 2025 09:18
@boring-cyborg boring-cyborg bot added area:providers provider:snowflake Issues related to Snowflake provider labels Mar 15, 2025
@rawwar rawwar requested review from Lee-W and gopidesupavan March 15, 2025 13:03
@rawwar rawwar changed the title fix: correctly parse private_key_content in snowflake hooks fix: fix parsing of private_key_content in snowflake hooks Mar 15, 2025
@potiuk
Copy link
Member

potiuk commented Mar 17, 2025

As explained in #47003 -> I think better solution would be to extend the password widget to not replace the \n - alternatively we could extend the previous multi-line widget to use password type control and show **

@rawwar rawwar marked this pull request as draft March 17, 2025 16:20
@rawwar
Copy link
Contributor Author

rawwar commented Apr 23, 2025

closing this as #49467 is merged

@rawwar rawwar closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:snowflake Issues related to Snowflake provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snowflake provider: The private_key_content field is no longer a multi-line text input in Connections

2 participants