Ensures DatabricksWorkflowOperator updates ACL (if available) when resetting a job. #47827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
from
c13647c to
ce4d7c4
Compare
|
:-) |
Contributor
|
@hardeybisey , can we add a test? |
Contributor
Author
Sure, I will add the test and tag you once it's done. |
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
4 times, most recently
from
9b387d1 to
1172e6c
Compare
Contributor
Author
|
@rawwar I have added test to the PR. |
pankajkoti
reviewed
Apr 7, 2025
providers/databricks/src/airflow/providers/databricks/operators/databricks_workflow.py
Outdated
Show resolved
Hide resolved
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
from
116bcfe to
5695ffe
Compare
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
4 times, most recently
from
48b115e to
7512fe3
Compare
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
2 times, most recently
from
48e11b0 to
db2767e
Compare
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
2 times, most recently
from
db2767e to
a7f48ff
Compare
hardeybisey
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
from
a7f48ff to
73e2141
Compare
Contributor
Author
|
@rawwar @pankajkoti Could you please review this PR at your convenience? Thanks for your time. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
eladkal
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
from
73e2141 to
78ee8ee
Compare
eladkal
removed
the
stale
pankajkoti
force-pushed
the
update-acl-on-databricks-workflowoperator-reset
branch
from
78ee8ee to
49f6fab
Compare
pankajkoti
approved these changes
Aug 8, 2025
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
LGTM. @hardeybisey, sorry for the delay in reviewing here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...
closes: #45738
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.