-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Don't expect default connections to be present #47968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
o-nikolas
merged 3 commits into
apache:main
from
aws-mwaa:onikolas/s3_transfer_connections_issue
Mar 20, 2025
Merged
Don't expect default connections to be present #47968
o-nikolas
merged 3 commits into
apache:main
from
aws-mwaa:onikolas/s3_transfer_connections_issue
Mar 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airflow does not create default connections by default and this operator was expecting them to be present and throwing exceptions. We should only expect the connection to be present if the user explicitly passed that connection name to us (rather than receiving it as a default value)
vincbeck
approved these changes
Mar 19, 2025
ferruzzi
approved these changes
Mar 19, 2025
providers/amazon/src/airflow/providers/amazon/aws/transfers/redshift_to_s3.py
Show resolved
Hide resolved
hussein-awala
approved these changes
Mar 19, 2025
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
Airflow does not create default connections by default and this operator was expecting them to be present and throwing exceptions. We should only expect the connection to be present if the user explicitly passed that connection name to us (rather than receiving it as a default value)
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Mar 22, 2025
Airflow does not create default connections by default and this operator was expecting them to be present and throwing exceptions. We should only expect the connection to be present if the user explicitly passed that connection name to us (rather than receiving it as a default value)
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Airflow does not create default connections by default and this operator was expecting them to be present and throwing exceptions. We should only expect the connection to be present if the user explicitly passed that connection name to us (rather than receiving it as a default value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow does not create default connections by default and this operator was expecting them to be present and throwing exceptions. We should only expect the connection to be present if the user explicitly passed that connection name to us (rather than receiving it as a default value)
related: https://github.com/apache/airflow/pull/47414/files
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.