Skip to content

Conversation

@Prab-27
Copy link
Contributor

@Prab-27 Prab-27 commented Mar 20, 2025

closes: #47975


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be updated as well: providers/fab/src/airflow/providers/fab/auth_manager/models/db.py

@Prab-27
Copy link
Contributor Author

Prab-27 commented Mar 20, 2025

Ya! Updated

When I ran breeze testing providers-tests --run-in-parallel --run-db-tests-only --parallel-test-types "Providers[fab]" to test these changes it showed me some errors while running the tests and displayed: There were errors when running some tasks. Quitting.

Could you please help me how to solve this ?

@vincbeck
Copy link
Contributor

vincbeck commented Mar 20, 2025

Ya! Updated

When I ran breeze testing providers-tests --run-in-parallel --run-db-tests-only --parallel-test-types "Providers[fab]" to test these changes it showed me some errors while running the tests and displayed: There were errors when running some tasks. Quitting.

Could you please help me how to solve this ?

Sure, I'll wait for the tests to finish and then take a look

@Prab-27
Copy link
Contributor Author

Prab-27 commented Mar 21, 2025

Thanks!!

@ephraimbuddy ephraimbuddy merged commit e0bbf51 into apache:main Mar 21, 2025
89 checks passed
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Mar 21, 2025
…ce (apache#48000)

* moving create_db_orm to be a public method in db manager

* move create_db_from_orm to be a public method in fab provider

* Update providers/fab/src/airflow/providers/fab/auth_manager/models/db.py

---------

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Mar 22, 2025
…ce (apache#48000)

* moving create_db_orm to be a public method in db manager

* move create_db_from_orm to be a public method in fab provider

* Update providers/fab/src/airflow/providers/fab/auth_manager/models/db.py

---------

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
…ce (apache#48000)

* moving create_db_orm to be a public method in db manager

* move create_db_from_orm to be a public method in fab provider

* Update providers/fab/src/airflow/providers/fab/auth_manager/models/db.py

---------

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move "create db from orm" to be a public method in db manager interface

3 participants