Merged
Conversation
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
67b6b78 to
ba8a858
Compare
7 tasks
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
ba8a858 to
f79df7e
Compare
uranusjr
requested review from
ashb,
eladkal,
hussein-awala,
o-nikolas and
potiuk
as code owners
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
f79df7e to
4cfe4bd
Compare
eladkal
reviewed
Mar 20, 2025
providers/amazon/src/airflow/providers/amazon/aws/notifications/sns.py
Outdated
Show resolved
Hide resolved
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
4cfe4bd to
46cb31d
Compare
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
46cb31d to
1e5baa8
Compare
uranusjr
requested review from
amoghrajesh,
gopidesupavan and
kaxil
as code owners
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
5 times, most recently
from
34bde78 to
3326449
Compare
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
2 times, most recently
from
cfbf5aa to
082aa46
Compare
potiuk
reviewed
Mar 25, 2025
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
0cfcd08 to
615c3ce
Compare
An entry is added to the compat provider for all providers to use.
uranusjr
force-pushed
the
move-notifier-to-sdk
branch
from
615c3ce to
56db697
Compare
kaxil
approved these changes
Mar 25, 2025
eladkal
approved these changes
Mar 25, 2025
Contributor
|
We need also to set version for common.compat that is installed by default with Airflow 3 don't we? Lines 54 to 62 in 243fe86 I'm not sure if we have the mechanism to set min provider version for core? |
Member
Author
|
Airflow Core does not need newest compat; it does not use BaseNotifier. This class is only used in providers (and user code). The class is actually invoked by a protocol (using |
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
An entry is added to the compat provider for all providers to use.
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
An entry is added to the compat provider for all providers to use.
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
An entry is added to the compat provider for all providers to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An entry is added to the compat provider for all providers to use.
For #45424.