Skip to content

fix: compat test test_provider_not_installed failing on main #48012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jedcunningham merged 1 commit into from
Mar 20, 2025
Merged

fix: compat test test_provider_not_installed failing on main #48012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions providers/common/compat/tests/unit/common/compat/test_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,34 +56,35 @@ def dummy_function():

@patch("importlib.metadata.version", return_value="0.9.9")
def test_provider_version_lower_than_required(mock_version):
@require_provider_version("apache-airflow-providers-mockprovider", "1.0.0")
@require_provider_version("apache-airflow-providers-nonexistingprovidermock", "1.0.0")
def dummy_function():
return "Function Executed"

with pytest.raises(
AirflowOptionalProviderFeatureException,
match=r"Provider's `apache-airflow-providers-mockprovider` version `0.9.9` is lower than required `1.0.0`",
match=r"Provider's `apache-airflow-providers-nonexistingprovidermock` "
r"version `0.9.9` is lower than required `1.0.0`",
):
dummy_function()


@patch("importlib.import_module", side_effect=ImportError)
@patch("importlib.metadata.version", side_effect=metadata.PackageNotFoundError)
@patch("importlib.import_module", side_effect=ModuleNotFoundError)
def test_provider_not_installed(mock_import, mock_version):
@require_provider_version("apache-airflow-providers-mockprovider", "1.0.0")
def test_provider_not_installed(mock_version, mock_import):
@require_provider_version("apache-airflow-providers-nonexistingprovidermock", "1.0.0")
def dummy_function():
return "Function Executed"

with pytest.raises(
AirflowOptionalProviderFeatureException,
match=r"Provider `apache-airflow-providers-mockprovider` not found or has no version",
match=r"Provider `apache-airflow-providers-nonexistingprovidermock` not found or has no version",
):
dummy_function()


@patch("importlib.metadata.version", return_value="2.0.0")
def test_provider_version_ok(mock_version):
@require_provider_version("apache-airflow-providers-mockprovider", "1.0.0")
@require_provider_version("apache-airflow-providers-nonexistingprovidermock", "1.0.0")
def dummy_function():
return "Function Executed"

Expand All @@ -94,7 +95,7 @@ def dummy_function():
@patch("importlib.import_module", return_value=type("module", (), {"__version__": "1.5.0"}))
@patch("importlib.metadata.version", side_effect=metadata.PackageNotFoundError)
def test_provider_dynamic_import(mock_version, mock_import):
@require_provider_version("apache-airflow-providers-mockprovider", "1.0.0")
@require_provider_version("apache-airflow-providers-nonexistingprovidermock", "1.0.0")
def dummy_function():
return "Function Executed"

Expand Down