-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3987] Unify GCP's Connection IDs #4818
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
- Coverage 75.74% 75.74% -0.01%
==========================================
Files 458 458
Lines 29850 29849 -1
==========================================
- Hits 22609 22608 -1
Misses 7241 7241
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb!
Unify GCP's Connection IDs; Merge with master
40f98c8
to
54a925a
Compare
PTAL @kaxil |
I'll have a look at this tonight or at most by the end of this week :) |
@ryanyuan Could you resolve the conflicts? :-) |
UPDATING.md
Outdated
variant. Values like ``google_cloud_storage_default``, ``bigquery_default``, | ||
``google_cloud_datastore_default`` have been abandoned. The configuration of | ||
connections in the database have been preserved, but in every place where they | ||
were used, they should be indicated explicitly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rephrase the last line ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits. LGTM
Co-Authored-By: ryanyuan <ryan.yuan@outlook.com>
Update UPDATING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @ryanyuan
Unify GCP's Connection IDs
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation
Code Quality
flake8