AIP-72: Move logic to load Secrets backend on Workers #48446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function. The changes in this commit unifies how we handle it to the 2.x side and on the API-server side. https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
ashb
approved these changes
Mar 27, 2025
sunank200
approved these changes
Mar 27, 2025
amoghrajesh
reviewed
Mar 27, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Yeah parity with AF 2 is always good, thanks!
3 tasks
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function. The changes in this commit unifies how we handle it to the 2.x side and on the API-server side. https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function. The changes in this commit unifies how we handle it to the 2.x side and on the API-server side. https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function. The changes in this commit unifies how we handle it to the 2.x side and on the API-server side. https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function. The changes in this commit unifies how we handle it to the 2.x side and on the API-server side. https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even the default backend is only loaded when the supervise process is called via initialize_secrets_backend_on_workers. This makes it difficult to test any operator without calling that function.
The changes in this commit unifies how we handle it to the 2.x side and on the API-server side.
https://github.com/apache/airflow/blob/2.10.5/airflow/models/connection.py#L524-L536
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.