Cookies in non TLS mode #48453
Merged
Cookies in non TLS mode #48453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
eladkal,
o-nikolas and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
bugraoz93
approved these changes
Mar 27, 2025
vincbeck
reviewed
Mar 27, 2025
airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py
Outdated
Show resolved
Hide resolved
vincbeck
reviewed
Mar 27, 2025
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/router/login.py
Outdated
Show resolved
Hide resolved
Member
Author
|
Also added handling in the SAM /ui setCookie, and doc update. |
pierrejeambrun
force-pushed
the
cookies-in-non-tls-mode
branch
from
5b9842f to
93ab579
Compare
vincbeck
approved these changes
Mar 27, 2025
pierrejeambrun
force-pushed
the
cookies-in-non-tls-mode
branch
4 times, most recently
from
422b570 to
8dbeef5
Compare
pierrejeambrun
force-pushed
the
cookies-in-non-tls-mode
branch
from
8dbeef5 to
9f2f84c
Compare
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #47859 to extend it to all auth managers.
Cookies shouldn't have the attribute secure if the cluster is not using https