Move bases classes to airflow.sdk.bases
#48487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
requested review from
XD-DENG,
amoghrajesh,
ashb,
bolkedebruin,
eladkal,
ephraimbuddy,
gopidesupavan,
jedcunningham,
josh-fell,
mobuchowski,
o-nikolas,
pierrejeambrun,
potiuk,
rawwar and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
ashb
reviewed
Mar 28, 2025
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_xcom.py
Outdated
Show resolved
Hide resolved
ashb
reviewed
Mar 28, 2025
Contributor
|
Would sdk.base look better? based sounds a little weird to me |
kaxil
force-pushed
the
move-baseop
branch
2 times, most recently
from
91a8a51 to
7956c59
Compare
Member
Author
|
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
Contributor
Yes definitely. It just felt a little odd :) But thats ok |
amoghrajesh
approved these changes
Mar 28, 2025
sunank200
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
These class aren't needed in DAG definition -- not atleast by DAG Authors This PR moves core base classes to a dedicated `airflow.sdk.bases` module to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators. Key Changes: - Created new `airflow.sdk.bases` module - Moved base classes: - `BaseOperator` -> `airflow.sdk.bases.baseoperator` - `BaseSensorOperator` -> `airflow.sdk.bases.sensor` - `BaseOperatorLink` -> `airflow.sdk.bases.operatorlink` - `BaseNotifier` -> `airflow.sdk.bases.notifier` - `XCom` -> `airflow.sdk.bases.xcom`
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These class aren't needed in DAG definition -- not atleast by DAG Authors
This PR moves core base classes to a dedicated
airflow.sdk.basesmodule to clarify their intended usage. These classes are internal implementation details and not meant for direct use by DAG authors. They are meant to be used by Providers developer or developer of custom operators.Key Changes:
airflow.sdk.basesmoduleBaseOperator->airflow.sdk.bases.baseoperatorBaseSensorOperator->airflow.sdk.bases.sensorBaseOperatorLink->airflow.sdk.bases.operatorlinkBaseNotifier->airflow.sdk.bases.notifierBaseXCom->airflow.sdk.bases.xcom^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.