Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

#48579 and #48528 removed Sequential and Debug Executors. We should add significant newsfrags for these as it is a behaviour change for end users.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@amoghrajesh amoghrajesh requested a review from Lee-W April 2, 2025 06:35
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for user to set something to Sequential/Debug Executor in code or config?

@amoghrajesh
Copy link
Contributor Author

Nah I do not think so from looking at the code

@amoghrajesh
Copy link
Contributor Author

@Lee-W there is a possibility of doing something of that sort in "core \ executor" config but we shield it now and do not allow it.

@amoghrajesh amoghrajesh requested a review from eladkal April 2, 2025 06:40
@Lee-W
Copy link
Member

Lee-W commented Apr 2, 2025

Nah I do not think so from looking at the code

How do people set it to Sequential / Debug in the past?

@amoghrajesh
Copy link
Contributor Author

cc @eladkal maybe you are the right person for this, can these executors be set anywhere in the code / config?

@amoghrajesh
Copy link
Contributor Author

Nah I do not think so from looking at the code

How do people set it to Sequential / Debug in the past?

It was using either the config or env variable: https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/index.html

@Lee-W
Copy link
Member

Lee-W commented Apr 2, 2025

Nah I do not think so from looking at the code

How do people set it to Sequential / Debug in the past?

It was using either the config or env variable: https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/index.html

Then I think we might still need a config rule then?

@amoghrajesh
Copy link
Contributor Author

Wondering that too. Is it possible to have a rule to override either of those to LocalExec?

@Lee-W
Copy link
Member

Lee-W commented Apr 2, 2025

Wondering that too. Is it possible to have a rule to override either of those to LocalExec?

We could add it to the airflow config lint section. Then, we'll figure out how we do it later.

@amoghrajesh
Copy link
Contributor Author

@Lee-W let me do that yeah

@amoghrajesh amoghrajesh requested a review from Lee-W April 3, 2025 06:28
@amoghrajesh
Copy link
Contributor Author

@eladkal that change has been made. I am getting the debugexecutor doc refs removed too.

Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@amoghrajesh amoghrajesh requested a review from Lee-W April 4, 2025 15:47
@amoghrajesh amoghrajesh merged commit fe652c8 into apache:main Apr 8, 2025
49 checks passed
@amoghrajesh amoghrajesh deleted the removed-executor-newsfrag branch April 8, 2025 04:38
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants