Skip to content

Conversation

@amoghrajesh
Copy link
Contributor

types-protobuf 5.29.1.20250402 was released today and it seems that this one is a partial stub package. https://peps.python.org/pep-0561/#partial-stub-packages.

Due to this, mypy complains of [import-untyped] which basically means type annotations arent present.

Disallowing this version for google provider. Google provider depends on devel-common so in conjunction the right version will be picked imo.

Example failure:

providers/google/src/airflow/providers/google/cloud/hooks/dataproc.py:60: error:
Library stubs not installed for "google.protobuf.field_mask_pb2" 
[import-untyped]
        from google.protobuf.field_mask_pb2 import FieldMask
    ^
providers/google/src/airflow/providers/google/cloud/hooks/cloud_memorystore.py:53: error:
Library stubs not installed for "google.protobuf.field_mask_pb2" 
[import-untyped]
        from google.protobuf.field_mask_pb2 import FieldMask

https://github.com/apache/airflow/actions/runs/14214004343/job/39826852033


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 2, 2025
@potiuk potiuk merged commit 3a4fa61 into apache:main Apr 2, 2025
151 of 152 checks passed
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
diogotrodrigues pushed a commit to diogotrodrigues/airflow that referenced this pull request Apr 6, 2025
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants