Remove extra slash character from file URI formation in MetastoreHivePartitionSensor.poke method.
#48731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
eladkal
reviewed
Apr 3, 2025
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
can you add unit test for this change?
please also amend the commit message and PR title to explain what is the bug that you are fixing. Saying Fix MetastoreHivePartitionSensor is not very informative when presented in the change log.
Crowiant
force-pushed
the
fix-metastore-hive-partition-sensor
branch
from
47b7f75 to
073eef3
Compare
Crowiant
changed the title
MetastoreHivePartitionSensor.poke method.
Contributor
Author
|
Hello @eladkal ! Thank you for the comment. I've made some changes based on your feedback. Could you please take another look? |
Crowiant
force-pushed
the
fix-metastore-hive-partition-sensor
branch
from
073eef3 to
b4541ef
Compare
eladkal
approved these changes
Apr 4, 2025
…ePartitionSensor.poke` method.
eladkal
force-pushed
the
fix-metastore-hive-partition-sensor
branch
from
b4541ef to
231aa9b
Compare
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…reHivePartitionSensor.poke` method. (apache#48731) Co-authored-by: Anton Nitochkin <nitochkin@google.com>
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
…reHivePartitionSensor.poke` method. (apache#48731) Co-authored-by: Anton Nitochkin <nitochkin@google.com>
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
…reHivePartitionSensor.poke` method. (apache#48731) Co-authored-by: Anton Nitochkin <nitochkin@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently MetastoreHivePartitionSensor throwing errors like:
Failure caused by Failed to download file with query result: 404 GET https://storage.googleapis.com/download/storage/v1/b/gcs-bucket-metastore-hive-partition-sensor-nitochkin-5636390b-6/o/query-results%2F3da345c3-f116-43bd-a68f-8bfa27366dc5%2F%2Fresult-001?alt=media: No such object: gcs-bucket-metastore-hive-partition-sensor-nitochkin-5636390b-6/query-results/3da345c3-f116-43bd-a68f-8bfa27366dc5//result-001: ('Request failed with status code', 404, 'Expected one of', <HTTPStatus.OK: 200>, <HTTPStatus.PARTIAL_CONTENT: 206>)
It is because of the wrong file_uri formation.
This is the fix to eliminate the problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.