-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add single endpoint to retrieve menu information #48762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf5cd0a to
8e5257f
Compare
providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py
Outdated
Show resolved
Hide resolved
a5001be to
a35b2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Yes I agree that this mapping MenuItem.EVENTS: RESOURCE_AUDIT_LOG is confusing. (Even in the UI event vs asset event, I find AUDIT_LOG less confusing)
A couple of small nits, but looking good to me.
airflow-core/src/airflow/api_fastapi/core_api/openapi/v1-generated.yaml
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/openapi/v1-generated.yaml
Outdated
Show resolved
Hide resolved
a35b2fe to
11c60b9
Compare
I renamed "Events" to "Audit log" then |
|
Tests are unrelated to this PR. Merging |
|
Was this the right change? Asset events are different from events (a.k.a. event log a.k.a. audit log) and also different from |
There's no asset event page yet, but there is an 'AUDIT_LOG' one. We will most likely add the |
i see, so it only looked like a rename in the diff but was not a rename; just, we did not need it yet. |
|
I think so yes |
Part of #47412.
Create one endpoint to retrieve menu information. Two pieces of information are retrieved:
authorized_menu_items: the list of menu items the user has access toextra_menu_items: the list of menu items provided by the auth manager. We used to have a endpoint to retrieve that information. I removed that endpoint since it is unnecessary to have 2 endpointsI updated the front-end code to no longer use the
/ui/auth/linksendpoint but the new one. Once that merged, we need to update the front-end code to display/hide menu items depending on whether it belongs toauthorized_menu_items. @bbovenzi^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.