Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Apr 4, 2025

Nothing currently uses them, but passing this down allows for a lot more
control for custom log readers.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@ashb ashb requested review from eladkal and o-nikolas as code owners April 4, 2025 18:15
@boring-cyborg boring-cyborg bot added area:logging area:providers provider:alibaba provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues labels Apr 4, 2025
@ashb ashb changed the title Add ti to the RemoteLogIO read and upload functions Add ti to the RemoteLogIO read function Apr 4, 2025
@ashb ashb changed the title Add ti to the RemoteLogIO read function Add ti to the RemoteLogIO read method Apr 4, 2025
Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Nothing currently uses them, but passing this down allows for a lot more
control for custom log readers.
@ashb ashb force-pushed the change-remote-log-io-interface branch from b095acf to 56f2c5b Compare April 4, 2025 18:59
@ashb ashb changed the title Add ti to the RemoteLogIO read method Add ti to the RemoteLogIO read and upload methods Apr 4, 2025
@ashb
Copy link
Member Author

ashb commented Apr 4, 2025

Non DB Provider tests failure is being fixed in #48808

@ashb ashb merged commit 1025474 into apache:main Apr 4, 2025
65 of 67 checks passed
@ashb ashb deleted the change-remote-log-io-interface branch April 4, 2025 20:05
@jscheffl
Copy link
Contributor

jscheffl commented Apr 4, 2025

FYI @AutomationDev85 seems something has moved in direction of logs in TaskSDK where I was not watchign carefully :-D

@ashb
Copy link
Member Author

ashb commented Apr 4, 2025

Hopefully it'll be stable now!

nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
Nothing currently uses them, but passing this down allows for a lot more
control for custom log readers.
diogotrodrigues pushed a commit to diogotrodrigues/airflow that referenced this pull request Apr 6, 2025
Nothing currently uses them, but passing this down allows for a lot more
control for custom log readers.
simonprydden pushed a commit to simonprydden/airflow that referenced this pull request Apr 8, 2025
Nothing currently uses them, but passing this down allows for a lot more
control for custom log readers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:alibaba provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants