Fix Celery Executor on Airflow 2.x again. #48806
Conversation
Prior to 984c61d this code looked like: ```python result = task_to_run.apply_async(args=[command], queue=queue) ``` Closes apache#47781
|
Let me test it |
|
Works ! Tested with 2.10.5! 
|
|
I think we should yank 3.10.1 -> 3.10.4 after releasing 3.10.5. They will neither work on 2 nor on final 3 (I guess) |
|
Ah you beat me to testing it, thanks. |
|
3.10.2+ would work on Airflow 3, but yeah lets yank |
|
Lets not yank if they work on Airflow 3.. it will give Airflow 3 users the option to run with Celery 5.4 should they want to |
|
Some of 3.1-3.4 might not work on any 3 versions. There were multiple changes implemented since 3.10.1 and some of them look really bad if you look at the changelog - so while 3.10.4 might work, I am pretty sure 3.10.1 -> 3.10.3 won't ... It's safer to yank them all I think rather than loose time on checking which one works and which one does not. Especially that 3.10.5 also has the higher celery version which fixes another issue, it's likely safer to say "Please don't use 3.10.1 -> 3.10.4" IMHO. But feel free to decide. |
|
BTW: We don't loose anything by yanking... We can only risk some issues if we don't :) |
Prior to 984c61d this code looked like: ```python result = task_to_run.apply_async(args=[command], queue=queue) ``` Closes apache#47781
Prior to 984c61d this code looked like: ```python result = task_to_run.apply_async(args=[command], queue=queue) ``` Closes apache#47781
Prior to 984c61d this code looked like: ```python result = task_to_run.apply_async(args=[command], queue=queue) ``` Closes apache#47781
3 participants
Prior to 984c61d this code looked like:
Closes #47781
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.