-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Change provider-specific dependencies to refer to providers #48843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With the recent `uv` move, we can move some of the optional dependencies to providers - i.e. rather than refer to specific dependenciesm we can refer to the optional dependencies of the providers. This was not easy before - because with `pip` for development dependencies it would have install the provider itself instead of the dependencies, but with uv workspaces this is perfectly fine as uv will find the provider in the workspace and will install the provider sources and the optional dependencies when given extra is used. This avoids duplication in the core's dependencies and allows to depend airflow core noot on specific dependencies but on the optional dependencies of provider installed, which is as it should be. This change also bumps the dependencies of amazon provider that are affected by this change in an attempt to make "resolution too deep" problems.
ce1b53b to
9d00ad6
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Crossing fingers that the resolution too Deep will go away by this!
|
Let's see if it will help for the "resolution too deep". I am in a plain above the Atlantic now ;) so with low network speed no chance to test it locally for image building, but 1) far less number of combos for Amazon, 2) it's likely that having the dependencies on both - extra and different versions of providers made it difficult for |
…8843) With the recent `uv` move, we can move some of the optional dependencies to providers - i.e. rather than refer to specific dependenciesm we can refer to the optional dependencies of the providers. This was not easy before - because with `pip` for development dependencies it would have install the provider itself instead of the dependencies, but with uv workspaces this is perfectly fine as uv will find the provider in the workspace and will install the provider sources and the optional dependencies when given extra is used. This avoids duplication in the core's dependencies and allows to depend airflow core noot on specific dependencies but on the optional dependencies of provider installed, which is as it should be. This change also bumps the dependencies of amazon provider that are affected by this change in an attempt to make "resolution too deep" problems.
…8843) With the recent `uv` move, we can move some of the optional dependencies to providers - i.e. rather than refer to specific dependenciesm we can refer to the optional dependencies of the providers. This was not easy before - because with `pip` for development dependencies it would have install the provider itself instead of the dependencies, but with uv workspaces this is perfectly fine as uv will find the provider in the workspace and will install the provider sources and the optional dependencies when given extra is used. This avoids duplication in the core's dependencies and allows to depend airflow core noot on specific dependencies but on the optional dependencies of provider installed, which is as it should be. This change also bumps the dependencies of amazon provider that are affected by this change in an attempt to make "resolution too deep" problems.
…8843) With the recent `uv` move, we can move some of the optional dependencies to providers - i.e. rather than refer to specific dependenciesm we can refer to the optional dependencies of the providers. This was not easy before - because with `pip` for development dependencies it would have install the provider itself instead of the dependencies, but with uv workspaces this is perfectly fine as uv will find the provider in the workspace and will install the provider sources and the optional dependencies when given extra is used. This avoids duplication in the core's dependencies and allows to depend airflow core noot on specific dependencies but on the optional dependencies of provider installed, which is as it should be. This change also bumps the dependencies of amazon provider that are affected by this change in an attempt to make "resolution too deep" problems.
With the recent
uvmove, we can move some of the optional dependencies to providers - i.e. rather than refer to specific dependenciesm we can refer to the optional dependencies of the providers. This was not easy before - because withpipfor development dependencies it would have install the provider itself instead of the dependencies, but with uv workspaces this is perfectly fine as uv will find the provider in the workspace and will install the provider sources and the optional dependencies when given extra is used.This avoids duplication in the core's dependencies and allows to depend airflow core noot on specific dependencies but on the optional dependencies of provider installed, which is as it should be.
This change also bumps the dependencies of amazon provider that are affected by this change in an attempt to make "resolution too deep" problems.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.