Skip to content

Conversation

@dabla
Copy link
Contributor

@dabla dabla commented Apr 7, 2025

Added paginated_sql_statement_clause parameter to GenericTransfer and made it templated


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Aug 5, 2025

@dabla the tests are failing with

FAILED providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py::TestGenericTransfer::test_template_fields - TypeError: Invalid arguments were passed to GenericTransfer (task_id: transfer_table). Invalid arguments were:
**kwargs: {'paginated_sql_statement_format': '{} OFFSET {} ROWS FETCH NEXT {} ROWS ONLY;'}

@dabla
Copy link
Contributor Author

dabla commented Aug 6, 2025

@dabla the tests are failing with

FAILED providers/common/sql/tests/unit/common/sql/operators/test_generic_transfer.py::TestGenericTransfer::test_template_fields - TypeError: Invalid arguments were passed to GenericTransfer (task_id: transfer_table). Invalid arguments were:
**kwargs: {'paginated_sql_statement_format': '{} OFFSET {} ROWS FETCH NEXT {} ROWS ONLY;'}

@eladkal Fixed the test

@dabla dabla changed the title Added paginated_sql_statement_format parameter to GenericTransfer Added paginated_sql_statement_clause parameter to GenericTransfer Aug 6, 2025
@dabla dabla requested a review from eladkal August 6, 2025 10:00
@potiuk potiuk merged commit 438e426 into apache:main Aug 22, 2025
75 checks passed
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
…ache#48866)

* refactor: Added paginated_sql_statement_format as a GenericTransfer parameter and made it templated field

* refactor: Made the paginated_sql_statement_format param public instead of protected

* refactor: Renamed paginated_sql_statement_format to paginated_sql_statement_clause

* refactor: Fixed and removed duplicate test_templated_fields

---------

Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants