-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Added paginated_sql_statement_clause parameter to GenericTransfer #48866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 34 commits into
apache:main
from
dabla:feature/add-paginated-sql-param-generictransfer
Aug 22, 2025
Merged
Added paginated_sql_statement_clause parameter to GenericTransfer #48866
potiuk
merged 34 commits into
apache:main
from
dabla:feature/add-paginated-sql-param-generictransfer
Aug 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter and made it templated field
eladkal
reviewed
May 5, 2025
providers/common/sql/src/airflow/providers/common/sql/operators/generic_transfer.py
Outdated
Show resolved
Hide resolved
Contributor
|
@dabla the tests are failing with |
Contributor
Author
@eladkal Fixed the test |
potiuk
approved these changes
Aug 22, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…ache#48866) * refactor: Added paginated_sql_statement_format as a GenericTransfer parameter and made it templated field * refactor: Made the paginated_sql_statement_format param public instead of protected * refactor: Renamed paginated_sql_statement_format to paginated_sql_statement_clause * refactor: Fixed and removed duplicate test_templated_fields --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added paginated_sql_statement_clause parameter to GenericTransfer and made it templated
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.