Skip to content

Conversation

@simonprydden
Copy link
Contributor

closes #48434


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@simonprydden
Copy link
Contributor Author

@eladkal I messed up the other PR when rebasing :( #48436

I have updated the tests to reflect that send a change event does not actually return anything. How should we handle the change to the users? I don't believe it's returned an ID for a very long time.

@eladkal
Copy link
Contributor

eladkal commented Apr 9, 2025

@eladkal I messed up the other PR when rebasing :( #48436

I have updated the tests to reflect that send a change event does not actually return anything. How should we handle the change to the users? I don't believe it's returned an ID for a very long time.

If there is no impact from Airflow side then no further action required. If there is impact we can cut breaking change release and explain what is changed.

The way I see it, we didn't break anything in our interface and users can migrate from old package to new one without any code changes.

@simonprydden simonprydden marked this pull request as ready for review April 17, 2025 09:07
@eladkal
Copy link
Contributor

eladkal commented Apr 17, 2025

I see that CI didn't pickup the updated library for constraints so I will trigger force upgrade to see how it goes
Screenshot 2025-04-17 at 13 20 56

@eladkal eladkal added the upgrade to newer dependencies If set, upgrade to newer dependencies is forced label Apr 17, 2025
@eladkal
Copy link
Contributor

eladkal commented Apr 17, 2025

@simonprydden can you rebase the PR and resolve conflicts?

@eladkal eladkal merged commit 4772292 into apache:main Apr 17, 2025
73 checks passed
@simonprydden simonprydden deleted the Migrate-from-pdpyras-to-pagerduty branch April 17, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:pagerduty upgrade to newer dependencies If set, upgrade to newer dependencies is forced

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from pdpyras to pagerduty

2 participants