Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Apr 8, 2025

Instead of using BranchMixIn, we should use BaseBranchOperator -- otherwise why have that Base class!


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Apr 11, 2025

Tests are failing

Instead of using `BranchMixIn`, we should use `BaseBranchOperator`  -- otherwise why have that Base class!
@kaxil kaxil force-pushed the inherit-basebranch-op branch from ca5dbfe to 7b11d97 Compare April 28, 2025 21:37
@eladkal eladkal merged commit 75d56f1 into apache:main Apr 29, 2025
64 checks passed
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
Instead of using `BranchMixIn`, we should use `BaseBranchOperator`  -- otherwise why have that Base class!
mvfc pushed a commit to mvfc/airflow that referenced this pull request Apr 29, 2025
Instead of using `BranchMixIn`, we should use `BaseBranchOperator`  -- otherwise why have that Base class!
jroachgolf84 pushed a commit to jroachgolf84/airflow that referenced this pull request Apr 30, 2025
Instead of using `BranchMixIn`, we should use `BaseBranchOperator`  -- otherwise why have that Base class!
@kaxil kaxil deleted the inherit-basebranch-op branch December 31, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants