-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4058] Rename models tests #4901
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4901 +/- ##
==========================================
+ Coverage 75.3% 75.53% +0.22%
==========================================
Files 450 450
Lines 29034 29034
==========================================
+ Hits 21865 21931 +66
+ Misses 7169 7103 -66
Continue to review full report at Codecov.
|
@ffinfo It seems that since we merged this commit something has happened to our logging config in tests, and we now see everything at debug level in the logs (example https://travis-ci.org/apache/airflow/jobs/504637817 compared to the build on master just before https://travis-ci.org/apache/airflow/jobs/504628389) which makes it even harder to find failures :( I can't see anything in the diff that might cause this, but maybe there was some side-effect from somewhere else? Would you have a spare hour to try and look at what is causing it? |
@ashb I did do some tracing but I think the cause is not in this merge request. I checked my own fork on travis. Here on the same commit it did not happen: The only difference between the build is that travis did a auto rebase on master before build, see also: This means that between my latest rebase/merge and the point where I did create the PR there was an other change on master that did caused this. I will try to back trace this to the commit on master that did cause this. And make a PR to fix this. |
Thanks for taking the time! @XD-DENG tracked it to this commit on master, but we couldn't see anything obvious that might cause it either. |
…pache#4901) We had `from .models import *` inside test/__init__.py as a kludge around this test file not being named according to expected Python conventions. Renaming the file makes more test tools happier (and makes it easier to run a single test file without importing half of the test tree which the current approach suffers from)
…pache#4901) We had `from .models import *` inside test/__init__.py as a kludge around this test file not being named according to expected Python conventions. Renaming the file makes more test tools happier (and makes it easier to run a single test file without importing half of the test tree which the current approach suffers from)
…pache#4901) We had `from .models import *` inside test/__init__.py as a kludge around this test file not being named according to expected Python conventions. Renaming the file makes more test tools happier (and makes it easier to run a single test file without importing half of the test tree which the current approach suffers from)
Make sure you have checked all steps below.
Jira
Description
Renaming models.py to test_models.py
Tests
Commits
Documentation
Code Quality
flake8