Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 10, 2025

Why

Some of the airflow config lint rules was not implemented back to the time changes were made. Also found some outdated newsfragments

What

  • Add the following airflow config lint rules
    • core.dag_default_view
    • core.dag_orientation
  • update outdated newsframgments

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W Lee-W requested a review from amoghrajesh April 10, 2025 10:36
@Lee-W
Copy link
Member Author

Lee-W commented Apr 10, 2025

there're still some rules not implemented but I'm out of bandwidth to work on them at this moment

@Lee-W Lee-W self-assigned this Apr 10, 2025
Lee-W added 5 commits April 10, 2025 19:35
…nificant.rst

reading apache#48528, it suggest users to use dag.test() instead of replacing the value as dag.test()
…heduler.create_delta_data_intervals to config lint
…s and scheduler.create_delta_data_intervals to config lint"

This reverts commit e60bfe3.
@Lee-W Lee-W force-pushed the update-news-fragments branch from e60bfe3 to 640daa1 Compare April 10, 2025 11:35
@Lee-W
Copy link
Member Author

Lee-W commented Apr 10, 2025

Revert the following rules as they're failing and I'm out of bandwidth to take a deeper look

  • scheduler.create_cron_data_intervals
  • scheduler.create_delta_data_intervals

@Lee-W Lee-W merged commit 1e93678 into apache:main Apr 10, 2025
50 checks passed
@Lee-W Lee-W deleted the update-news-fragments branch April 10, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants