Skip to content

Conversation

@vincbeck
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/fab_changelog branch 2 times, most recently from e403541 to ff51e39 Compare April 10, 2025 19:44
@eladkal eladkal self-requested a review April 11, 2025 07:33
@vincbeck vincbeck force-pushed the vincbeck/fab_changelog branch from 0a02748 to eff6d6b Compare April 11, 2025 13:26
@bugraoz93
Copy link
Contributor

Oops, I approved twice

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@vincbeck can you address the open comments?

@vincbeck vincbeck force-pushed the vincbeck/fab_changelog branch from eff6d6b to a0bf4ba Compare April 15, 2025 13:07
@vincbeck
Copy link
Contributor Author

LGTM @vincbeck can you address the open comments?

Done

vincbeck and others added 3 commits April 15, 2025 09:59
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
@vincbeck vincbeck force-pushed the vincbeck/fab_changelog branch from a0bf4ba to 5742d7e Compare April 15, 2025 13:59
@vincbeck
Copy link
Contributor Author

Test failures unrelated to this PR. Merging

@vincbeck vincbeck merged commit bd6b429 into apache:main Apr 15, 2025
45 of 49 checks passed
@vincbeck vincbeck deleted the vincbeck/fab_changelog branch April 15, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants