Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4076] Correct port type of beeline_default #4908

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

zhongjiajie
Copy link
Member

airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal(AIP).

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer
@XD-DENG
Copy link
Member

XD-DENG commented Mar 13, 2019

Thanks @zhongjiajie

I have restarted the failing tests. After CI passes, I will merge.

@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #4908 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4908      +/-   ##
==========================================
+ Coverage   75.54%   75.56%   +0.01%     
==========================================
  Files         451      451              
  Lines       29099    29099              
==========================================
+ Hits        21983    21988       +5     
+ Misses       7116     7111       -5
Impacted Files Coverage Δ
airflow/utils/db.py 90.38% <ø> (ø) ⬆️
airflow/configuration.py 94.4% <0%> (+0.34%) ⬆️
airflow/contrib/kubernetes/kube_client.py 75% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eb94f...ca0ca45. Read the comment docs.

@XD-DENG XD-DENG merged commit e2f138e into apache:master Mar 13, 2019
@zhongjiajie zhongjiajie deleted the db_clear_default_port_type branch March 13, 2019 07:51
@zhongjiajie
Copy link
Member Author

Thanks. @XD-DENG

ashb pushed a commit that referenced this pull request Mar 21, 2019
airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer
ashb pushed a commit that referenced this pull request Mar 22, 2019
airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
…e#4908)

airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
…e#4908)

airflow initdb will create default beeline connection
with port "10000", but airflow.models.connection
variable port is Integer type. It's better to set
values in same type as int although it could auto
transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants