Fix: SQLExecuteQueryOperator does not pass extra_dejson values to hook_params #49282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandharvishnu
force-pushed
the
hook_params_common_sql
branch
from
b230dc0 to
42747fb
Compare
RNHTTR
reviewed
Apr 15, 2025
kandharvishnu
force-pushed
the
hook_params_common_sql
branch
from
42747fb to
7fa2f6e
Compare
RNHTTR
reviewed
Apr 16, 2025
RNHTTR
approved these changes
Apr 17, 2025
kandharvishnu
force-pushed
the
hook_params_common_sql
branch
from
7fa2f6e to
9a77653
Compare
rawwar
reviewed
Apr 22, 2025
providers/common/sql/tests/unit/common/sql/operators/test_sql.py
Outdated
Show resolved
Hide resolved
rawwar
approved these changes
Apr 22, 2025
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
…k_params (apache#49282) * adding test cases * changing to extra_dejson * updating redis_hook * Update providers/common/sql/tests/unit/common/sql/operators/test_sql.py --------- Co-authored-by: Kalyan R <kalyan.ben10@live.com>
31 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #49273
This PR fixes an issue in
SQLExecuteQueryOperatorwhere values from the connection’s extra_dejson are not passed to hook_params, even though the operator extends BaseSQLOperator, which supports them.Currently, users have to manually duplicate values from the connection’s extras in the hook_params of the operator. This PR ensures that values in extra_dejson are automatically passed to hook_params, unless they are explicitly overridden.