Make sure all openapi schemas have distinct names #49290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When redoc includes, rather than embeds the openapi schemes, it loads them from the same folder. If the files have the same names they will be overwritten. This PR changes the openapi schemes to all have distinct, unique names.
potiuk
requested review from
ashb,
bbovenzi,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
pierrejeambrun,
rawwar,
ryanahamilton and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
potiuk
changed the title
kaxil
approved these changes
Apr 15, 2025
ashb
approved these changes
Apr 15, 2025
amoghrajesh
approved these changes
Apr 15, 2025
vincbeck
approved these changes
Apr 15, 2025
eladkal
approved these changes
Apr 15, 2025
Member
Author
|
Tests failing with main broken in #49239 |
potiuk
deleted the
make-sure-openapi-generated-specs-have-different-names
branch
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redoc includes, rather than embeds the openapi schemes, it loads them from the same folder. If the files have the same names they will be overwritten.
This PR changes the openapi schemes to all have distinct, unique names.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.