Fix failing tests after subdir path bundle URL merged #49294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ephraimbuddy,
kaxil and
pierrejeambrun
and removed request for
pierrejeambrun
Member
Author
|
@pierrejeambrun @ephraimbuddy - not 100% sure if that is the right expectation for unit tests but it looks pretty reasonable. |
Member
Author
|
We can also revert the offending b9052ee |
ephraimbuddy
approved these changes
Apr 15, 2025
The apache#49239 broke main with tests not updated after changing subpath
potiuk
force-pushed
the
fix-failing-tests-with-dag-subpath
branch
from
22f201b to
de0072f
Compare
aritra24
approved these changes
Apr 15, 2025
Member
|
YOLO since I ran this locally |
Member
Author
me too/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #49239 broke main with tests not updated after changing subpath
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.