Skip to content

fix: correct invalid arg timeout #49426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Apr 21, 2025
Merged

fix: correct invalid arg timeout #49426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/apache/kafka/src/airflow/providers/apache/kafka/hooks/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_connection(self) -> tuple[bool, str]:
"""Test Connectivity from the UI."""
try:
config = self.get_connection(self.kafka_config_id).extra_dejson
t = AdminClient(config, timeout=10).list_topics()
t = AdminClient(config).list_topics(timeout=10)
if t:
return True, "Connection successful."
except Exception as e:
Expand Down
8 changes: 6 additions & 2 deletions providers/apache/kafka/tests/unit/apache/kafka/hooks/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ def test_test_connection(self, mock_get_connection, admin_client, hook):
config = {"bootstrap.servers": MagicMock()}
mock_get_connection.return_value.extra_dejson = config
connection = hook.test_connection()
admin_client.assert_called_once_with(config, timeout=10)
admin_client.assert_called_once_with(config)
mock_admin_instance = admin_client.return_value
mock_admin_instance.list_topics.assert_called_once_with(timeout=TIMEOUT)
assert connection == (True, "Connection successful.")

@mock.patch(
Expand All @@ -68,7 +70,9 @@ def test_test_connection_no_topics(self, mock_get_connection, admin_client, hook
config = {"bootstrap.servers": MagicMock()}
mock_get_connection.return_value.extra_dejson = config
connection = hook.test_connection()
admin_client.assert_called_once_with(config, timeout=TIMEOUT)
admin_client.assert_called_once_with(config)
mock_admin_instance = admin_client.return_value
mock_admin_instance.list_topics.assert_called_once_with(timeout=TIMEOUT)
assert connection == (False, "Failed to establish connection.")

@mock.patch("airflow.providers.apache.kafka.hooks.base.AdminClient")
Expand Down