Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4127] _get_instance_view returns instance view #4945

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

Trollgeir
Copy link
Contributor

Jira

https://issues.apache.org/jira/browse/AIRFLOW-4127

Description

Simple bugfix for method _get_instance_view that returned current_view instead of an instance_view

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@XD-DENG
Copy link
Member

XD-DENG commented Mar 22, 2019

Thank you @Trollgeir . LGTM. Will merge once CI pass (I have re-triggered two failing ones to see if they're transient failure)

@codecov-io
Copy link

Codecov Report

Merging #4945 into master will increase coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4945      +/-   ##
==========================================
+ Coverage   75.58%   75.82%   +0.23%     
==========================================
  Files         454      454              
  Lines       29197    30004     +807     
==========================================
+ Hits        22069    22750     +681     
- Misses       7128     7254     +126
Impacted Files Coverage Δ
...low/contrib/hooks/azure_container_instance_hook.py 75% <0%> (ø) ⬆️
airflow/utils/decorators.py 84.48% <0%> (-7.19%) ⬇️
airflow/contrib/executors/kubernetes_executor.py 64.58% <0%> (-0.65%) ⬇️
airflow/contrib/operators/gcp_vision_operator.py 100% <0%> (ø) ⬆️
airflow/contrib/example_dags/example_gcp_vision.py 0% <0%> (ø) ⬆️
airflow/contrib/hooks/aws_glue_catalog_hook.py 100% <0%> (ø) ⬆️
airflow/models/__init__.py 92.95% <0%> (+0.1%) ⬆️
airflow/contrib/hooks/gcp_api_base_hook.py 82.06% <0%> (+1.11%) ⬆️
airflow/utils/helpers.py 85.47% <0%> (+2.59%) ⬆️
airflow/jobs.py 79.76% <0%> (+2.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f037e...a92f24c. Read the comment docs.

@XD-DENG XD-DENG merged commit 84c25bc into apache:master Mar 22, 2019
ashb pushed a commit that referenced this pull request Apr 2, 2019
cthenderson pushed a commit to cthenderson/apache-airflow that referenced this pull request Apr 16, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants