Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Apr 19, 2025

Related Issue

closes #49314

Why

columnNameCharacterMap option is already available in SQL but was missing in GCSToBigQueryOperator for CSV files.
To allow the options could be better handling of column names with special characters in CSV files

How

  • Simple addition of columnNameCharacterMap to the src_fmt_to_configs_mapping constant for CSV format

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 19, 2025
@guan404ming guan404ming marked this pull request as draft April 19, 2025 12:49
@guan404ming guan404ming force-pushed the support-column-name-character-map branch from 4d05f44 to 832c298 Compare April 19, 2025 13:46
@guan404ming guan404ming marked this pull request as ready for review April 19, 2025 13:46
Copy link

@perttus perttus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guan404ming guan404ming force-pushed the support-column-name-character-map branch 3 times, most recently from eeea514 to 48aadd2 Compare April 29, 2025 02:29
@guan404ming guan404ming changed the title feat: add columnNameCharacterMap option to GCSToBigQueryOperator Add columnNameCharacterMap option to GCSToBigQueryOperator Apr 30, 2025
@guan404ming guan404ming force-pushed the support-column-name-character-map branch 2 times, most recently from 2cd66b0 to 2648468 Compare May 1, 2025 05:27
@guan404ming
Copy link
Member Author

@Lee-W @jason810496 could you help review this? Thanks a lots!

@guan404ming guan404ming force-pushed the support-column-name-character-map branch from 2648468 to fb5a061 Compare May 2, 2025 00:56
@eladkal eladkal merged commit 3721d10 into apache:main May 2, 2025
68 checks passed
@guan404ming
Copy link
Member Author

Thanks for the review.

@guan404ming guan404ming deleted the support-column-name-character-map branch May 2, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCSToBigQueryOperator add columnNameCharacterMap to src_fmt_configs

3 participants