Skip to content

Conversation

@guan404ming
Copy link
Member

Related Issue

#49319

Why

Using the deprecated return_single_query_results, thus triggers deprecation warning.

How

Update them to use the stable function


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Apr 19, 2025

Do these updated import paths exist in the min version of common.sql for these providers? if not we need to bump it

@guan404ming
Copy link
Member Author

Not really sure how to check it, is there any hints?
But it works well in Provider Distribution Test
Thanks in advance~

@eladkal
Copy link
Contributor

eladkal commented Apr 20, 2025

Not really sure how to check it, is there any hints? But it works well in Provider Distribution Test Thanks in advance~

Using git history to track the commit that created this.
#43747
released with common.sql 1.21

@guan404ming
Copy link
Member Author

Thanks for helping out~
It seems like the providers' common.sql that I modified is all on 1.20.0 thus I bumped them all into 1.21.0

@eladkal eladkal merged commit 49181cf into apache:main Apr 21, 2025
67 checks passed
@guan404ming guan404ming deleted the update-return_single_query_results branch April 21, 2025 17:58
@guan404ming
Copy link
Member Author

Thanks for reviewing~

prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
* chore: update deprecated functions to use the stable functions

* env: bump common.sql to `1.21.0`
@guan404ming guan404ming changed the title chore: update deprecated functions to use the stable functions Update deprecated functions to use the stable functions Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants