Skip to content

feat: add expire_time configuration to OracleHook connection #49521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 1 commit into from
Apr 22, 2025
Merged

feat: add expire_time configuration to OracleHook connection #49521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions providers/oracle/src/airflow/providers/oracle/hooks/oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ def get_conn(self) -> oracledb.Connection:
elif purity == "default":
conn_config["purity"] = oracledb.PURITY_DEFAULT

expire_time = conn.extra_dejson.get("expire_time")
if expire_time:
conn_config["expire_time"] = expire_time

conn = oracledb.connect(**conn_config) # type: ignore[assignment]
if mod is not None:
conn.module = mod
Expand Down
9 changes: 9 additions & 0 deletions providers/oracle/tests/unit/oracle/hooks/test_oracle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,15 @@ def test_get_conn_purity(self, mock_connect):
assert args == ()
assert kwargs["purity"] == purity.get(pur)

@mock.patch("airflow.providers.oracle.hooks.oracle.oracledb.connect")
def test_get_conn_expire_time(self, mock_connect):
self.connection.extra = json.dumps({"expire_time": 10})
self.db_hook.get_conn()
assert mock_connect.call_count == 1
args, kwargs = mock_connect.call_args
assert args == ()
assert kwargs["expire_time"] == 10

@mock.patch("airflow.providers.oracle.hooks.oracle.oracledb.connect")
def test_set_current_schema(self, mock_connect):
self.connection.schema = "schema_name"
Expand Down