Fix get_uri for oracle
#49533
Merged
Fix get_uri for oracle
#49533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbj
approved these changes
Apr 22, 2025
cjbj
left a comment
cjbj
left a comment
There was a problem hiding this comment.
Looks fine from inspection, and with my limited background into the "schema" param.
I suspect the "extra" params may need some attention, but that is also something I don't know about at the moment.
Lee-W
approved these changes
Apr 22, 2025
jason810496
approved these changes
Apr 22, 2025
guan404ming
force-pushed
the
fix-oracle-get-uri
branch
2 times, most recently
from
36749a0 to
505d2f7
Compare
Co-Authored-By: Christopher Jones <christopher.jones@oracle.com>
Co-Authored-By: Christopher Jones <christopher.jones@oracle.com>
guan404ming
force-pushed
the
fix-oracle-get-uri
branch
from
505d2f7 to
2791a8b
Compare
Member
Author
|
Thanks for the review |
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
* fix: get_uri for oracle Co-Authored-By: Christopher Jones <christopher.jones@oracle.com> * test: remove invalid test Co-Authored-By: Christopher Jones <christopher.jones@oracle.com> --------- Co-authored-by: Christopher Jones <christopher.jones@oracle.com>
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
* fix: get_uri for oracle Co-Authored-By: Christopher Jones <christopher.jones@oracle.com> * test: remove invalid test Co-Authored-By: Christopher Jones <christopher.jones@oracle.com> --------- Co-authored-by: Christopher Jones <christopher.jones@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#48734 (comment)
Why
ref: https://docs.sqlalchemy.org/en/20/dialects/oracle.html#dialect-oracle-oracledb-connect
How
cc: @cjbj @Lee-W @jason810496 @h30306
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.