Tweak Execution API OpenAPI spec to improve code Generation #49700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
commented
Apr 24, 2025
ashb
commented
Apr 24, 2025
kaxil
approved these changes
Apr 24, 2025
This change improves the generated code using the OpenAPI schema: - `anyOf` to `oneOf` so that generated clients don't try _all_ schemas, but stop after the first - Fix the header pattern to make it valid against the spec - Use the function name as the default operation ID in the spec. On this last part, this is a different implementation (but same effect) to how we do operation name in the Core API. I will change CoreAPI to use this same method in a separate PR, but I didn't want to touch both APIs in this PR for clarity of git history
ashb
force-pushed
the
anyof-to-oneof-exec-api-schema
branch
from
b4e6eb1 to
1d467f7
Compare
amoghrajesh
approved these changes
Apr 24, 2025
kaxil
pushed a commit
that referenced
this pull request
Apr 24, 2025
This change improves the generated code using the OpenAPI schema: - `anyOf` to `oneOf` so that generated clients don't try _all_ schemas, but stop after the first - Fix the header pattern to make it valid against the spec - Use the function name as the default operation ID in the spec. On this last part, this is a different implementation (but same effect) to how we do operation name in the Core API. I will change CoreAPI to use this same method in a separate PR, but I didn't want to touch both APIs in this PR for clarity of git history (cherry picked from commit 1df5b41)
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
…9700) This change improves the generated code using the OpenAPI schema: - `anyOf` to `oneOf` so that generated clients don't try _all_ schemas, but stop after the first - Fix the header pattern to make it valid against the spec - Use the function name as the default operation ID in the spec. On this last part, this is a different implementation (but same effect) to how we do operation name in the Core API. I will change CoreAPI to use this same method in a separate PR, but I didn't want to touch both APIs in this PR for clarity of git history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the generated code using the OpenAPI schema:
anyOftooneOfso that generated clients don't try all schemas, butstop after the first
On this last part, this is a different implementation (but same effect) to how
we do operation name in the Core API. I will change CoreAPI to use this same
method in a separate PR, but I didn't want to touch both APIs in this PR for
clarity of git history
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.