Remove direct access to DB for safe_to_cancel() method for Dataproc and BigQuery triggers #49711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
pankajkoti
reviewed
Apr 24, 2025
providers/google/src/airflow/providers/google/cloud/triggers/bigquery.py
Show resolved
Hide resolved
pankajkoti
reviewed
Apr 24, 2025
providers/google/src/airflow/providers/google/cloud/triggers/bigquery.py
Outdated
Show resolved
Hide resolved
sunank200
reviewed
Apr 24, 2025
providers/google/src/airflow/providers/google/cloud/triggers/bigquery.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py
Outdated
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/triggers/bigquery.py
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py
Show resolved
Hide resolved
sunank200
reviewed
Apr 24, 2025
Collaborator
sunank200
left a comment
sunank200
left a comment
There was a problem hiding this comment.
Do we need to change tests for this?
…nd BigQuery triggers
MaksYermak
force-pushed
the
change-safe-to-cancel-functionality-for-af3
branch
from
f5823bc to
2eba0cf
Compare
Contributor
Author
In my opinion no. The current tests check this functionality and I think it's enough. |
potiuk
approved these changes
May 19, 2025
Member
|
@sunank200 -> are you ok with this ? |
pankajkoti
approved these changes
May 23, 2025
providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py
Show resolved
Hide resolved
providers/google/src/airflow/providers/google/cloud/triggers/dataproc.py
Show resolved
Hide resolved
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…nd BigQuery triggers (apache#49711)
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…nd BigQuery triggers (apache#49711)
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #49187
In this PR I have removed direct access to DB for the
safe_to_cancel()method for Dataproc and BigQuery triggers for Airflow 3. I have added the new logic under theAIRFLOW_V_3_0_PLUSif-statement for being sure that thegoogleprovider will be compatible with Airflow 2 and Airflow 3.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.