Skip to content

Fix infinite redirect caused by mistakenly setting token cookie as secure #49721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 1 commit into from
Apr 24, 2025
Merged

Fix infinite redirect caused by mistakenly setting token cookie as secure #49721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/docs/core-concepts/auth-manager/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ delete the cookie.

response = RedirectResponse(url="/")

secure = conf.has_option("api", "ssl_cert")
secure = bool(conf.get("api", "ssl_cert", fallack=""))
response.set_cookie(COOKIE_NAME_JWT_TOKEN, token, secure=secure)
return response

Expand Down
10 changes: 7 additions & 3 deletions airflow-core/src/airflow/api_fastapi/auth/managers/simple/routes/login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

from __future__ import annotations

from fastapi import status
from fastapi import Request, status
from starlette.responses import RedirectResponse

from airflow.api_fastapi.auth.managers.base_auth_manager import COOKIE_NAME_JWT_TOKEN
Expand Down Expand Up @@ -57,10 +57,14 @@ def create_token_all_admins() -> LoginResponse:
status_code=status.HTTP_307_TEMPORARY_REDIRECT,
responses=create_openapi_http_exception_doc([status.HTTP_403_FORBIDDEN]),
)
def login_all_admins() -> RedirectResponse:
def login_all_admins(request: Request) -> RedirectResponse:
"""Login the user with no credentials."""
response = RedirectResponse(url=conf.get("api", "base_url", fallback="/"))
secure = conf.has_option("api", "ssl_cert")

# The default config has this as an empty string, so we can't use `has_option`.
# And look at the request info (needs `--proxy-headers` flag to api-server)
secure = request.base_url.scheme == "https" or bool(conf.get("api", "ssl_cert", fallback=""))

response.set_cookie(
COOKIE_NAME_JWT_TOKEN,
SimpleAuthManagerLogin.create_token_all_admins(),
Expand Down