[v3-0-test] add SimpleAllAdminMiddleware to allow api usage without auth header in request (#49599) #49743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uth header in request (#49599) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope (cherry picked from commit 003bf6d) Co-authored-by: Kalyan R <kalyan.ben10@live.com>
pierrejeambrun
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
vincbeck
as code owners
Contributor
|
Need to merge #49716 before this EDIT: I forgot that I removed backfill tests that fail when passing invalid backfill_id. This PR does not depend on the other one now |
pierrejeambrun
approved these changes
Apr 24, 2025
kaxil
pushed a commit
that referenced
this pull request
Apr 24, 2025
…n request (#49599) (#49743) * add SimpleAllAdminMiddleware * add tests * update test * update test name * refactor test * sort test order * hardcode endpoints * use session * db_test mark * iterate over app.routes * use fewer endpoints * update comment * update scope (cherry picked from commit 003bf6d) Co-authored-by: Kalyan R <kalyan.ben10@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add SimpleAllAdminMiddleware
add tests
update test
update test name
refactor test
sort test order
hardcode endpoints
use session
db_test mark
iterate over app.routes
use fewer endpoints
update comment
update scope
(cherry picked from commit 003bf6d)
Co-authored-by: Kalyan R kalyan.ben10@live.com