Add map_index filter option to GetTICount and GetTaskStates #49818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
amoghrajesh,
ashb,
dstandish,
hussein-awala and
kaxil
as code owners
boring-cyborg
bot
added
area:API
gopidesupavan
commented
Apr 26, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
gopidesupavan
force-pushed
the
add-map-index-option
branch
from
0482073 to
6f27c55
Compare
amoghrajesh
reviewed
Apr 28, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Generally looks good, some comments.
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
gopidesupavan
commented
Apr 28, 2025
kaxil
approved these changes
Apr 28, 2025
Member
Author
|
@kaxil about cadwine migration comment, do we need to do it for this, is it manually i need to generate? |
kaxil
reviewed
Apr 28, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Show resolved
Hide resolved
kaxil
approved these changes
Apr 29, 2025
gopidesupavan
added
the
backport-to-v3-1-test
…nd fix to return only tasks under taskgroup when task group only provides
gopidesupavan
force-pushed
the
add-map-index-option
branch
from
173aefc to
a583cd7
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
…es (#49818) * Add map_index filter option to GetTICount and GetTaskStates * Add map_index filter option to GetTICount and GetTaskStates * Update get_task_instance_states response to include map index tasks and fix to return only tasks under taskgroup when task group only provides * Add tests * Resolve comments * Fix tests (cherry picked from commit 1099e08) Co-authored-by: GPK <gopidesupavan@gmail.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 29, 2025
…es (apache#49818) * Add map_index filter option to GetTICount and GetTaskStates * Add map_index filter option to GetTICount and GetTaskStates * Update get_task_instance_states response to include map index tasks and fix to return only tasks under taskgroup when task group only provides * Add tests * Resolve comments * Fix tests (cherry picked from commit 1099e08) Co-authored-by: GPK <gopidesupavan@gmail.com>
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
Apr 29, 2025
…9818) * Add map_index filter option to GetTICount and GetTaskStates * Add map_index filter option to GetTICount and GetTaskStates * Update get_task_instance_states response to include map index tasks and fix to return only tasks under taskgroup when task group only provides * Add tests * Resolve comments * Fix tests
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
…9818) * Add map_index filter option to GetTICount and GetTaskStates * Add map_index filter option to GetTICount and GetTaskStates * Update get_task_instance_states response to include map index tasks and fix to return only tasks under taskgroup when task group only provides * Add tests * Resolve comments * Fix tests
kaxil
pushed a commit
that referenced
this pull request
Apr 30, 2025
…es (#49818) (#49979) * Add map_index filter option to GetTICount and GetTaskStates * Add map_index filter option to GetTICount and GetTaskStates * Update get_task_instance_states response to include map index tasks and fix to return only tasks under taskgroup when task group only provides * Add tests * Resolve comments * Fix tests (cherry picked from commit 1099e08) Co-authored-by: GPK <gopidesupavan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding mapping index option to GetTICount and GetTaskStates.
The default option is None, because if the user not input any task_ids/task_group_id, we would want to fetch all the tasks that satsfies other condition(dag_id, run_ids).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.