[KubernetesPodOperator] Add fail fast detection during pod startup #49867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutomationDev85
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
AutomationDev85
changed the title
nevcohen
reviewed
May 6, 2025
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Outdated
Show resolved
Hide resolved
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Show resolved
Hide resolved
jscheffl
approved these changes
May 6, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
For me this looks good. But a second pair of eyes for approval from the experts would be good prior merge
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Show resolved
Hide resolved
AutomationDev85
force-pushed
the
feature/fast-fail-image-error-kubernetes-pod-operator
branch
from
8799915 to
e716be5
Compare
AutomationDev85
force-pushed
the
feature/fast-fail-image-error-kubernetes-pod-operator
branch
from
e716be5 to
0ae80cf
Compare
jscheffl
approved these changes
May 12, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Re-review - looks good to me.
This was referenced May 14, 2025
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…Operator (apache#49867) Co-authored-by: AutomationDev85 <AutomationDev85>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR extends the improvements of this PR: #49784
The idea is to detect failures like ErrImagePull or InvalidImageName fast to give fast feedback to the user. Without this the await_pod_start would wait until we run into the timeout. Failures like this can be detected fast and result in an failed Pod startup. E.g. 1) User gets fast feedback if they added the wrong image name. 2) User gets fast feedback if image is not available.
What is your opinion about this idea?
Details of change: