Skip to content

Conversation

@vuonghoangbntt
Copy link
Contributor

Description

Previously, only the 'verify' option was handled when creating the session for the Vault client.
This change extends it to also support 'cert' (client certificates) and 'proxies' passed via kwargs ensuring compatibility with the hvac client, which reads these values from the session. (HVAC Adapter)
image
This allows advanced connection configurations like mutual TLS authentication and proxy routing
while preserving retry logic.

Updated tests to cover proxies and client cert cases.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:hashicorp Hashicorp provider related issues labels Apr 28, 2025
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vuonghoangbntt vuonghoangbntt force-pushed the feature/add-cert-and-proxies-to-vault-client branch 2 times, most recently from 13872d0 to 7f2f33c Compare April 29, 2025 01:13
@eladkal eladkal force-pushed the feature/add-cert-and-proxies-to-vault-client branch from 7f2f33c to 5ebb427 Compare June 1, 2025 08:23
@eladkal eladkal requested a review from Lee-W June 1, 2025 08:23
@Lee-W Lee-W merged commit f1df240 into apache:main Jun 9, 2025
66 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 9, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:hashicorp Hashicorp provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants