Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 30, 2025

Why

Closes: #49714

What

Set upstream_map_indexes in TIRunContext and let it be assigned to RuntimeTaskInstance._upstream_map_indexes to be later used in XComArgs.resolve when the upstream is a task group


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:task-sdk labels Apr 30, 2025
@uranusjr uranusjr self-requested a review April 30, 2025 06:37
@Lee-W Lee-W force-pushed the fix-task-group branch 5 times, most recently from dcbee0d to 4a6bcd3 Compare April 30, 2025 15:08
@Lee-W Lee-W changed the title fix(task_group): correctly set upstream_map_indexes for mapped task g… Handle MappedTaskGroup map indexes Apr 30, 2025
@Lee-W Lee-W marked this pull request as ready for review April 30, 2025 15:10
@Lee-W Lee-W force-pushed the fix-task-group branch from 4a6bcd3 to 26be313 Compare May 2, 2025 01:55
@eladkal eladkal added this to the Airflow 3.0.1 milestone May 2, 2025
@Lee-W Lee-W force-pushed the fix-task-group branch 3 times, most recently from ebdeda6 to f79533c Compare May 2, 2025 10:36
@Lee-W Lee-W self-assigned this May 5, 2025
@Lee-W Lee-W force-pushed the fix-task-group branch from f79533c to 68285cc Compare May 5, 2025 08:46
@Lee-W
Copy link
Member Author

Lee-W commented May 5, 2025

As this is approved, comments addresssed, I'm going to merge this later today

@Lee-W Lee-W merged commit 5adeac2 into apache:main May 5, 2025
97 checks passed
@Lee-W Lee-W deleted the fix-task-group branch May 5, 2025 14:42
mvfc pushed a commit to mvfc/airflow that referenced this pull request May 6, 2025
* fix(task_group): correctly set upstream_map_indexes for mapped task group

* refactor(task_instance): refactor how upstream_map_indexes is handled

* test: fix broken tests

* fix(task_group): fix maaping handling

* refactor(task_instnaces): rewrite _get_upstream_map_indexes
kaxil pushed a commit that referenced this pull request May 6, 2025
* fix(task_group): correctly set upstream_map_indexes for mapped task group

* refactor(task_instance): refactor how upstream_map_indexes is handled

* test: fix broken tests

* fix(task_group): fix maaping handling

* refactor(task_instnaces): rewrite _get_upstream_map_indexes

(cherry picked from commit 5adeac2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapped task_group does not output list of combined results to consumer

4 participants