-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Handle MappedTaskGroup map indexes #49996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbee0d to
4a6bcd3
Compare
eladkal
approved these changes
May 2, 2025
uranusjr
reviewed
May 2, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Outdated
Show resolved
Hide resolved
ebdeda6 to
f79533c
Compare
tirkarthi
reviewed
May 2, 2025
airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
Show resolved
Hide resolved
Member
Author
|
As this is approved, comments addresssed, I'm going to merge this later today |
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
* fix(task_group): correctly set upstream_map_indexes for mapped task group * refactor(task_instance): refactor how upstream_map_indexes is handled * test: fix broken tests * fix(task_group): fix maaping handling * refactor(task_instnaces): rewrite _get_upstream_map_indexes
kaxil
pushed a commit
that referenced
this pull request
May 6, 2025
* fix(task_group): correctly set upstream_map_indexes for mapped task group * refactor(task_instance): refactor how upstream_map_indexes is handled * test: fix broken tests * fix(task_group): fix maaping handling * refactor(task_instnaces): rewrite _get_upstream_map_indexes (cherry picked from commit 5adeac2)
This was referenced May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes: #49714
What
Set
upstream_map_indexesinTIRunContextand let it be assigned toRuntimeTaskInstance._upstream_map_indexesto be later used inXComArgs.resolvewhen the upstream is a task group^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.