Skip to content

Conversation

@vincbeck
Copy link
Contributor

The following configs in section webserver have been removed while working on Airflow 3:

  • enable_proxy_fix
  • proxy_fix_x_for
  • proxy_fix_x_proto
  • proxy_fix_x_host
  • proxy_fix_x_port
  • proxy_fix_x_prefix

These configs were used by the main Flask application. Recently, we found out that we need these configs back because the FAB provider Flask application needs these ones. See #49942. As part of the same PR, we decided to move them from webserver to fab.

This PR updates the airflow config lint command to rename these configs. For those who already migrated, I think they will have to add back these configs manually (or there is another solution?).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@vincbeck vincbeck added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Apr 30, 2025
@boring-cyborg boring-cyborg bot added area:CLI area:helm-chart Airflow Helm Chart labels Apr 30, 2025
@vincbeck vincbeck force-pushed the vincbeck/fab_proxy_config branch from 85e1b54 to 4f555d5 Compare May 1, 2025 09:30
@vincbeck vincbeck merged commit c1a2b48 into apache:main May 1, 2025
65 checks passed
@vincbeck vincbeck deleted the vincbeck/fab_proxy_config branch May 1, 2025 10:14
github-actions bot pushed a commit that referenced this pull request May 1, 2025
(cherry picked from commit c1a2b48)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented May 1, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

kaxil pushed a commit that referenced this pull request May 1, 2025
(cherry picked from commit c1a2b48)

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI area:helm-chart Airflow Helm Chart backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants