Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3540] Warn if old airflow.cfg file is found #5006

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

ashb
Copy link
Member

@ashb ashb commented Mar 29, 2019

Make sure you have checked all steps below.

Jira

Description

  • People might have been caught by this situation of having (a dual config file) without even knowning it. To make it obvious for those people we should say if we found the old config file even if we don't read from it.

    Note: Against v1-10-stable branch, not master.

    A DeprecationWarning may not actually be the right thing here, as we aren't reading from it. Anyone have any thoughts?

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: tested manually.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

We used to read this config file, but we now don't. To make it easier on
users (particularly of puckel's docker container) lets at least issue a
warning
@ashb ashb requested review from feng-tao and XD-DENG March 29, 2019 18:41
@codecov-io
Copy link

Codecov Report

Merging #5006 into v1-10-stable will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           v1-10-stable   #5006      +/-   ##
===============================================
- Coverage            78%     78%   -0.01%     
===============================================
  Files               226     226              
  Lines             17626   17629       +3     
===============================================
+ Hits              13749   13751       +2     
- Misses             3877    3878       +1
Impacted Files Coverage Δ
airflow/configuration.py 89% <66.66%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691d069...e807498. Read the comment docs.

@feng-tao feng-tao merged commit 5406122 into apache:v1-10-stable Mar 29, 2019
@ashb ashb deleted the warn_old_config_file branch April 4, 2019 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants