Skip to content

[v3-0-test] Allow non-string valid JSON values in Variable import. (#49844) #50063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
May 1, 2025
Merged

[v3-0-test] Allow non-string valid JSON values in Variable import. (#49844) #50063

potiuk merged 2 commits into from
May 1, 2025

Conversation

@tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented May 1, 2025

(cherry picked from commit 61dfd44)

@boring-cyborg boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels May 1, 2025
@tirkarthi tirkarthi mentioned this pull request May 1, 2025
Merged
@tirkarthi tirkarthi changed the title Allow non-string valid JSON values in Variable import. (#49844) [v3-0-test] Allow non-string valid JSON values in Variable import. (#49844) May 1, 2025
@tirkarthi tirkarthi added this to the Airflow 3.0.1 milestone May 1, 2025
@tirkarthi
Copy link
Contributor Author

tirkarthi commented May 1, 2025

Cherry picked 21b8621 too since it's required for this PR.

@kaxil
Copy link
Member

kaxil commented May 1, 2025

Cherry picked 21b8621 too since it's required for this PR.

#49917 is about airflowctl only though? Which will be released as a separate project

@tirkarthi
Copy link
Contributor Author

tirkarthi commented May 1, 2025

Yes, I changed the data type for Variable value from str to JsonValue in airflow-core. airflowctl auto generates from airflow-core and needed the change in #49917 to support custom type JsonValue. Without that change in this PR tests for airflowctl will fail blocking the merge.

@potiuk potiuk merged commit f1efe19 into apache:v3-0-test May 1, 2025
73 checks passed
@bugraoz93
Copy link
Contributor

bugraoz93 commented May 1, 2025

We are keeping sync using a similar pre-commit to TaskSDK <-> Execution API in the airflowctl <-> Core API. Since it won't be released from there and main, it should be safe to keep the main sync altogether with these things without breaking :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@kaxil kaxil Awaiting requested review from kaxil kaxil is a code owner

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

Assignees

No one assigned

Labels

area:airflow-ctl area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tirkarthi @kaxil @bugraoz93 @potiuk